Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bindings for LocalMessageDefinitionSource #1697

Merged
merged 3 commits into from
Jun 8, 2024
Merged

Add bindings for LocalMessageDefinitionSource #1697

merged 3 commits into from
Jun 8, 2024

Conversation

methylDragon
Copy link
Contributor

Description

This adds bindings for LocalMessageDefinitionSource.get_full_text to rosbag2_py. I don't think it's too controversial.

Unit tests added and passed.

@methylDragon methylDragon requested a review from a team as a code owner June 7, 2024 03:22
@methylDragon methylDragon requested review from MichaelOrlov and james-rms and removed request for a team June 7, 2024 03:22
@methylDragon methylDragon force-pushed the ch3/message_definition_source_pybind branch 2 times, most recently from 3d238df to 301a21d Compare June 7, 2024 03:28
fujitatomoya
fujitatomoya approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with https://github.com/ros2/rosbag2/pull/1697/files#r1631359697 fixed.

methylDragon and others added 2 commits June 7, 2024 13:09
@methylDragon
Add bindings for LocalMessageDefinitionSource
11c1b0a 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Fix pyi interface definitions
0b6d099 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the ch3/message_definition_source_pybind branch from 301a21d to 0b6d099 Compare June 7, 2024 20:10
@methylDragon
Copy link
Contributor Author

Looks like I still need reviews from @MichaelOrlov / @james-rms

MichaelOrlov
MichaelOrlov reviewed Jun 7, 2024
View reviewed changes
Copy link
Contributor

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@methylDragon Thanks for the PR. Overall looks good to me among one minor finding with a typo.

As regards the changes in the .pyi files, Yes, they are supposed to be autogenerated. Please see the instruction in the readme file in the rosbag2_py package https://github.com/ros2/rosbag2/blob/rolling/rosbag2_py/README.md

rosbag2_py/src/rosbag2_py/_message_definitions.cpp Outdated Show resolved Hide resolved
@methylDragon @MichaelOrlov
Update rosbag2_py/src/rosbag2_py/_message_definitions.cpp
a2e984c 
Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
Signed-off-by: methylDragon <methylDragon@gmail.com>
MichaelOrlov
MichaelOrlov approved these changes Jun 8, 2024
View reviewed changes
Copy link
Contributor

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! with green CI.

@MichaelOrlov
Copy link
Contributor

Pulls: #1697
Gist: https://gist.githubusercontent.com/MichaelOrlov/e971eb33cd4164b7b2dcb9cb092fe7b9/raw/dc445ec0c9644a863e7458f6b19133245acade30/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_py rosbag2_tests ros2bag
TEST args: --packages-above rosbag2_py rosbag2_tests ros2bag
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14049

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@methylDragon methylDragon merged commit fbb08d0 into rolling Jun 8, 2024
14 checks passed
@methylDragon methylDragon deleted the ch3/message_definition_source_pybind branch June 8, 2024 05:05
@MichaelOrlov
Copy link
Contributor

https://github.com/Mergifyio backport jazzy

@mergify Mergify
Copy link

mergify bot commented Jun 8, 2024 •
edited
Loading

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 8, 2024
@methylDragon @mergify
Add bindings for LocalMessageDefinitionSource (#1697)
f0d475e 
* Add bindings for LocalMessageDefinitionSource

Signed-off-by: methylDragon <methylDragon@gmail.com>

* Fix pyi interface definitions

Signed-off-by: methylDragon <methylDragon@gmail.com>

* Update rosbag2_py/src/rosbag2_py/_message_definitions.cpp

Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
Signed-off-by: methylDragon <methylDragon@gmail.com>

---------

Signed-off-by: methylDragon <methylDragon@gmail.com>
Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
(cherry picked from commit fbb08d0)
@mergify mergify bot mentioned this pull request Jun 8, 2024
Merged
methylDragon added a commit that referenced this pull request Jun 10, 2024
@mergify @methylDragon
Add bindings for LocalMessageDefinitionSource (#1697) (#1701)
397eecc 
* Add bindings for LocalMessageDefinitionSource

Signed-off-by: methylDragon <methylDragon@gmail.com>

* Fix pyi interface definitions

Signed-off-by: methylDragon <methylDragon@gmail.com>

* Update rosbag2_py/src/rosbag2_py/_message_definitions.cpp

Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
Signed-off-by: methylDragon <methylDragon@gmail.com>

---------

Signed-off-by: methylDragon <methylDragon@gmail.com>
Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
(cherry picked from commit fbb08d0)

Co-authored-by: methylDragon <methylDragon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll left review comments

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@MichaelOrlov MichaelOrlov MichaelOrlov approved these changes

@james-rms james-rms Awaiting requested review from james-rms james-rms is a code owner automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@methylDragon @MichaelOrlov @mjcarroll @fujitatomoya