Explicitly add DLL directories for Windows before importing #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New in Python 3.8, we should call os.add_dll_directory for directories containing the DLLs we intend to import as well as their recursive dependencies. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
dirk-thomas
reviewed
May 16, 2020
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
dirk-thomas
approved these changes
May 16, 2020
nuclearsandwich
approved these changes
May 18, 2020
|
pjreed
pushed a commit
to pjreed/rosbag2
that referenced
this pull request
May 28, 2020
New in Python 3.8, we should call os.add_dll_directory for directories containing the DLLs we intend to import as well as their recursive dependencies. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Move logic to common package rpyutils Signed-off-by: Jacob Perron <jacob@openrobotics.org> Signed-off-by: P. J. Reed <preed@swri.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New in Python 3.8, we should call os.add_dll_directory for directories
containing the DLLs we intend to import as well as their recursive
dependencies.
Connects to ros2/ci#432