Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install headers to include/${PROJECT_NAME} #958

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Install headers to include/${PROJECT_NAME} #958

merged 1 commit into from
Feb 10, 2022

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Feb 5, 2022

Part of ros2/ros2#1150 - this installs headers to a unique directory in a merged workspace to avoid include directory search order issues when overriding packages.

@sloretz
Install headers to include/${PROJECT_NAME}
72070d2 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz requested a review from a team as a code owner February 5, 2022 00:20
@sloretz sloretz self-assigned this Feb 5, 2022
@sloretz sloretz requested review from emersonknapp and jhdcs and removed request for a team February 5, 2022 00:20
@sloretz
Copy link
Contributor Author

sloretz commented Feb 5, 2022

CI (build: --packages-up-to rosbag2_compression rosbag2_compression_zstd rosbag2_cpp rosbag2_performance_benchmarking rosbag2_storage rosbag2_storage_default_plugins rosbag2_test_common rosbag2_transport test: --packages-select rosbag2_compression rosbag2_compression_zstd rosbag2_cpp rosbag2_performance_benchmarking rosbag2_storage rosbag2_storage_default_plugins rosbag2_test_common rosbag2_transport)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@jhdcs
Copy link
Contributor

jhdcs commented Feb 7, 2022

Test number 22 for rosbag2_tramsport (test_play_services__rmw_fastrtps_cpp) had a timeout. Is that common with this test?

@sloretz
Copy link
Contributor Author

sloretz commented Feb 10, 2022

@jhdcs where do you see the test timeout? I don't see it timing out in either the CI jobs or the PR job.

I'll merge this for now, but if it's causing an issue I can revisit it.

@sloretz sloretz merged commit cc0e039 into master Feb 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the sloretz__rosbag2__include_projectname branch February 10, 2022 17:12
@jhdcs
Copy link
Contributor

jhdcs commented Feb 10, 2022

Hm. I thought I had seen it in the CI log, but perhaps I was mistaken?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbiggs gbiggs gbiggs approved these changes

@emersonknapp emersonknapp Awaiting requested review from emersonknapp emersonknapp is a code owner automatically assigned from ros2/tooling-reviewers

@jhdcs jhdcs Awaiting requested review from jhdcs jhdcs is a code owner automatically assigned from ros2/tooling-reviewers

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sloretz @jhdcs @gbiggs