Change the topic names in test_record.cpp #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've observed the 'test_record' series of tests sometimes succeeding and sometimes failing on https://ci.ros2.org, particularly in Windows builds. When it does fail, it shows error messages like this: [ERROR] [1649769476.588754000] [ROSBAG2_TRANSPORT]: Topic '/chatter' has more than one type associated. Only topics with one type are supported Given that we run tests sequentially (i.e. not in parallel), that really shouldn't be the case. However, we have noticed in the past that Windows can sometimes be extremely slow to cleanup processes from previous tests. Since many of our tests use a topic name of 'chatter', that is likely what is happening in this case. This change works around this problem by using an alternate name for the topics. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
requested review from
emersonknapp and
jhdcs
and removed request for
a team
|
CI:
|
gbiggs
approved these changes
Apr 13, 2022
|
The Rpr jobs are failing because of another flaky test ( |
delete-merged-branch
bot
deleted the
clalancette/change-test-topic-names
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've observed the 'test_record' series of tests sometimes
succeeding and sometimes failing on https://ci.ros2.org, particularly
in Windows builds. When it does fail, it shows error messages
like this:
[ERROR] [1649769476.588754000] [ROSBAG2_TRANSPORT]: Topic '/chatter' has more than one type associated. Only topics with one type are supported
Given that we run tests sequentially (i.e. not in parallel), that
really shouldn't be the case.
However, we have noticed in the past that Windows can sometimes
be extremely slow to cleanup processes from previous tests.
Since many of our tests use a topic name of 'chatter', that is
likely what is happening in this case. This change works around
this problem by using an alternate name for the topics.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org