Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.17.0 #1052

Merged
merged 1 commit into from
Aug 5, 2022
Merged

0.17.0 #1052

merged 1 commit into from
Aug 5, 2022

Conversation

MichaelOrlov
Copy link
Contributor

@clalancette @gbiggs @audrow I'd like to make new rosbag2 release for rolling.
We have accumulated substantial amount of changes and I think it's already time to release them.

Though, I am first time doing release. Please correct me or advise if I am doing something wrong.
I have prepared update for change logs and tried to bump minor version to 0.17.0

@MichaelOrlov MichaelOrlov requested a review from a team as a code owner July 31, 2022 00:17
@MichaelOrlov MichaelOrlov requested review from emersonknapp, jhdcs, audrow, clalancette and gbiggs and removed request for a team July 31, 2022 00:17
@gbiggs
Copy link
Member

gbiggs commented Jul 31, 2022

The only comment I have after a quick look over the changelogs is that usually we don't include a second level of bullet points in the changelog files.

Copy link
Contributor

@jhdcs jhdcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only saw a very minor grammatical issue. Otherwise this looks good to me!

rosbag2_compression_zstd/CHANGELOG.rst Outdated Show resolved Hide resolved
rosbag2_compression/CHANGELOG.rst Outdated Show resolved Hide resolved
rosbag2_cpp/CHANGELOG.rst Outdated Show resolved Hide resolved
rosbag2_storage/CHANGELOG.rst Outdated Show resolved Hide resolved
rosbag2_transport/CHANGELOG.rst Outdated Show resolved Hide resolved
@MichaelOrlov
Copy link
Contributor Author

The only comment I have after a quick look over the changelogs is that usually we don't include a second level of bullet points in the changelog files.

@gbiggs I am guessing that we didn't include a second level of bullets points because was not aware about important details in listed changes. And release preparation flow was to run a script, delete all second level bullet points which was actually message body from squashed merge commits.

Though I was the reviewer for every changes in this upcoming release and aware about some details and important changes which are not clear from one line in pull request title.
I decided to put a bit more details when it would be appropriate and nice to have for final user and added second level bullet items manually.

I've checked how it will be rendered. IMO it doesn't look weird or destructive. I found it to be very useful for final users.
Screenshot from 2022-08-01 17-27-03

@MichaelOrlov
Copy link
Contributor Author

@jhdcs I've addressed your comments about grammar.
Could you please verify and approve this PR?

Copy link
Contributor

@jhdcs jhdcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@MichaelOrlov
Copy link
Contributor Author

@jhdcs @clalancette I am sorry, (I messed up a little bit) I realized that yesterday I merged #1053 on rolling/master. And now I need to rebase this PR with 0.17.0.
I have done rebase and updated changelogs with information about #1053 in 2179c96
I also temporary deleted tag 0.17.0 since it was assigned to the commit which is somewhere in the middle.
As far as I understand I will need to assign 0.17.0 tag on rolling directly right after I will squash and merge commits from this PR.

Please let me know if my assumptions and proposed actions are correct and I can proceed with merge and tagging.

@MichaelOrlov
Copy link
Contributor Author

@clalancette @jhdcs Since I didn't get any response in 24 hours. I am going to go ahead and merge this PR.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

Generate changelogs for rosbag2 0.17.0

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

Update rosbag2_compression_zstd/CHANGELOG.rst

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com>

Update rosbag2_compression/CHANGELOG.rst

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com>

Update rosbag2_cpp/CHANGELOG.rst

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com>

Update rosbag2_storage/CHANGELOG.rst

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com>

Update rosbag2_transport/CHANGELOG.rst

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com>

Remove `instead` word in description of the #1010 in changelogs

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

Update changelogs with #1053 after rebase

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

Update changelogs details in regard to the optimization in writer

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov MichaelOrlov merged commit 21d4742 into rolling Aug 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the morlov/rolling-0.17.0 branch August 5, 2022 01:48
@MichaelOrlov
Copy link
Contributor Author

@clalancette @audrow I've tried to make release with bloom, however got error message about insufficient rights

bloom-release --rosdistro rolling rosbag2
ROS Distro index file associate with commit '0fa1904294ab891b243e231f14de8a995f3de3f9'
New ROS Distro index url: 'https://raw.githubusercontent.com/ros/rosdistro/0fa1904294ab891b243e231f14de8a995f3de3f9/index-v4.yaml'
==> Fetching 'rosbag2' repository from 'https://github.com/ros2-gbp/rosbag2-release.git'
Cloning into '/tmp/tmpwmey0xif'...
remote: Enumerating objects: 55104, done.
remote: Counting objects: 100% (4032/4032), done.
remote: Compressing objects: 100% (2947/2947), done.
remote: Total 55104 (delta 1181), reused 3676 (delta 944), pack-reused 51072
Receiving objects: 100% (55104/55104), 8.50 MiB | 6.60 MiB/s, done.
Resolving deltas: 100% (18329/18329), done.
==> Testing for push permission on release repository
==> git remote -v
origin	git@github.com:ros2-gbp/rosbag2-release.git (fetch)
origin	git@github.com:ros2-gbp/rosbag2-release.git (push)
==> git push --dry-run
ERROR: Permission to ros2-gbp/rosbag2-release.git denied to MichaelOrlov.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

It seems that I need to be in ros2-gbp/rosbag2 team to have permissions to push in those git repo.

I have created ros2-gbp/ros2-gbp-github-org#90 with request to join rosbag2 release team.

@MichaelOrlov MichaelOrlov linked an issue Aug 8, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make binary release for rosbag2 from rolling 0.17.0 tag
3 participants