-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.17.0 #1052
0.17.0 #1052
Conversation
The only comment I have after a quick look over the changelogs is that usually we don't include a second level of bullet points in the changelog files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only saw a very minor grammatical issue. Otherwise this looks good to me!
e2b3a73
to
5982e90
Compare
@gbiggs I am guessing that we didn't include a second level of bullets points because was not aware about important details in listed changes. And release preparation flow was to run a script, delete all second level bullet points which was actually message body from squashed merge commits. Though I was the reviewer for every changes in this upcoming release and aware about some details and important changes which are not clear from one line in pull request title. I've checked how it will be rendered. IMO it doesn't look weird or destructive. I found it to be very useful for final users. |
4d1677d
to
a2215b8
Compare
@jhdcs I've addressed your comments about grammar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
a2215b8
to
2179c96
Compare
@jhdcs @clalancette I am sorry, (I messed up a little bit) I realized that yesterday I merged #1053 on rolling/master. And now I need to rebase this PR with 0.17.0. Please let me know if my assumptions and proposed actions are correct and I can proceed with merge and tagging. |
@clalancette @jhdcs Since I didn't get any response in 24 hours. I am going to go ahead and merge this PR. |
Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Generate changelogs for rosbag2 0.17.0 Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Update rosbag2_compression_zstd/CHANGELOG.rst Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> Update rosbag2_compression/CHANGELOG.rst Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> Update rosbag2_cpp/CHANGELOG.rst Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> Update rosbag2_storage/CHANGELOG.rst Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> Update rosbag2_transport/CHANGELOG.rst Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> Remove `instead` word in description of the #1010 in changelogs Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Update changelogs with #1053 after rebase Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Update changelogs details in regard to the optimization in writer Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
98b671b
to
6dc3267
Compare
@clalancette @audrow I've tried to make release with bloom, however got error message about insufficient rights
It seems that I need to be in ros2-gbp/rosbag2 team to have permissions to push in those git repo. I have created ros2-gbp/ros2-gbp-github-org#90 with request to join |
@clalancette @gbiggs @audrow I'd like to make new
rosbag2
release forrolling
.We have accumulated substantial amount of changes and I think it's already time to release them.
Though, I am first time doing release. Please correct me or advise if I am doing something wrong.
I have prepared update for change logs and tried to bump minor version to 0.17.0