Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine root cause of the unpaused_sleep_returns_true test failure #1367

Closed
wants to merge 1 commit into from
Closed

Refine root cause of the unpaused_sleep_returns_true test failure #1367

wants to merge 1 commit into from

Conversation

MichaelOrlov
Copy link
Contributor

@MichaelOrlov
Refine root cause of the unpaused_sleep_returns_true test failure
90983dd 
- Follow up to the failure in https://ci.ros2.org/job/ci_windows/19597/

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov MichaelOrlov requested a review from a team as a code owner June 3, 2023 06:36
@MichaelOrlov MichaelOrlov requested review from gbiggs, hidmic and emersonknapp and removed request for a team and gbiggs June 3, 2023 06:36
This was referenced Jun 3, 2023
Merged
Merged
@emersonknapp emersonknapp mentioned this pull request Jun 7, 2023
Closed
emersonknapp
emersonknapp approved these changes Jun 9, 2023
View reviewed changes
Copy link
Collaborator

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I think we should merge this, and get the extra info for future test failures.

@emersonknapp
Copy link
Collaborator

Oh ... rclcpp::ok() was never true, ever. Nothing ever calls rclcpp::init() in this test suite! In fact, rclcpp::ok() is explicitly not a requirement - TimeControllerClock only calls a now_fn, it doesn't care about rclcpp status. The check that was added to the test in https://github.com/ros2/rosbag2/pull/1012/files#diff-ea9ff4b69cd29013d4599d8e20313ab1f1dd918e82e810755dad97abfd9f4a51R161 did exactly nothing, because if the clock has a spurious wakeup then rclcpp::ok() == false and the loop exits anyways.

emersonknapp
emersonknapp requested changes Jun 10, 2023
View reviewed changes
Copy link
Collaborator

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revoking approval since this will never be true

@emersonknapp emersonknapp mentioned this pull request Jun 10, 2023
Merged
@MichaelOrlov
Copy link
Contributor Author

@MichaelOrlov MichaelOrlov deleted the morlov/refine_unpaused_sleep_returns_true_test_failure branch September 16, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonknapp emersonknapp emersonknapp requested changes

@hidmic hidmic Awaiting requested review from hidmic hidmic is a code owner automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelOrlov @emersonknapp