disable some tests for connext #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
ivanpauno
approved these changes
Aug 27, 2019
|
aarch64 with only Connext is failing, because Connext isn't available in that platform. |
Karsten1987
added a commit
that referenced
this pull request
Aug 29, 2019
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Karsten1987
added a commit
that referenced
this pull request
Sep 9, 2019
thomas-moulard
pushed a commit
to thomas-moulard/rosbag2
that referenced
this pull request
Oct 22, 2019
* ros2GH-27 Implement discovery for new topics after startup - this allows new topics to be discovered also after startup. - as a consquence, ros2 bag record won't throw any exception anymore if the specified topics are not available at startup - each time the recorder subscribes to a new topic, this will be logged to console * ros2GH-27 Provide polling frequency as option - make option available in RecordOptions - set to 100ms for now * ros2GH-27 Stop topic polling if subscription setup is complete * ros2GH-27 Minor refactoring for readability * ros2GH-27 Fix build after rebase * ros2GH-145 add no-discovery option to ros2 bag record * ros2GH-27 Refactor subscribing mechanism - use set for subscribed topics instead of vector - perform the asynchronous call only when discovery is needed * ros2GH-27 Expose polling-interval as cli option * ros2GH-27 Minor refactoring * ros2GH-27 Refactor recorder - naming of methods - emphasize similarity between first subscription and discovery loop * small touch ups * remove launch from function name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI (only Connext):
CI (only FastRTPS):
Signed-off-by: Karsten Knese karsten@openrobotics.org