Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for false negative tests in rosbag2_py #1592

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Fix for false negative tests in rosbag2_py #1592

merged 2 commits into from
Mar 21, 2024

Conversation

MichaelOrlov
Copy link
Contributor

  • wait_for(condition: Callable, timout) was incorrectly returning True after the first iteration even if condition was false.

@MichaelOrlov MichaelOrlov requested a review from a team as a code owner March 19, 2024 19:08
@MichaelOrlov MichaelOrlov requested review from gbiggs, jhdcs and fujitatomoya and removed request for a team March 19, 2024 19:08
@MichaelOrlov
Copy link
Contributor Author

@r7vme Your help with a review here will be appreciated.

@MichaelOrlov MichaelOrlov mentioned this pull request Mar 19, 2024
Merged
@MichaelOrlov MichaelOrlov self-assigned this Mar 19, 2024
@r7vme
Copy link
Contributor

r7vme commented Mar 20, 2024

@MichaelOrlov changes look fine. I'm looking into failed python stubs check.

@r7vme
Copy link
Contributor

r7vme commented Mar 20, 2024

@MichaelOrlov fix for stub check #1593

@MichaelOrlov
Fix for false negative tests in rosbag2_py
51f5a0c 
-  wait_for(condition: Callable, timout) was incorrectly returning True
after the first iteration even if condition was false.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov MichaelOrlov force-pushed the morlov/fix_false_negative_tests_in_rosbag2_py branch from 22d49d4 to 51f5a0c Compare March 20, 2024 20:07
@MichaelOrlov
Copy link
Contributor Author

Gist: https://gist.githubusercontent.com/MichaelOrlov/69975b6955dc0647ebf8c9be60c63d50/raw/08c1efc912afc234eaed11a82873aa35e20a7476/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_py
TEST args: --packages-above rosbag2_py
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/13500

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@MichaelOrlov
Copy link
Contributor Author

@clalancette @emersonknapp Could some of you additionally formally approve this PR to be able to merge it?

clalancette
clalancette requested changes Mar 20, 2024
View reviewed changes
rosbag2_py/test/test_transport.py Outdated Show resolved Hide resolved
@MichaelOrlov
Address review comments in regards bag_path optimization
c47b619 
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov
Copy link
Contributor Author

Re-running CI after addressing additional review comments
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/13501

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

clalancette
clalancette approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for refactoring.

@MichaelOrlov MichaelOrlov merged commit 66af399 into rolling Mar 21, 2024
13 of 14 checks passed
@delete-merged-branch delete-merged-branch bot deleted the morlov/fix_false_negative_tests_in_rosbag2_py branch March 21, 2024 00:00
@MichaelOrlov
Copy link
Contributor Author

https://github.com/Mergifyio backport iron humble

@mergify Mergify
Copy link

mergify bot commented Jun 4, 2024 •
edited
Loading

backport iron humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 4, 2024
@MichaelOrlov @mergify
Fix for false negative tests in rosbag2_py (#1592)
514650b 
* Fix for false negative tests in rosbag2_py

-  wait_for(condition: Callable, timout) was incorrectly returning True
after the first iteration even if condition was false.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

* Address review comments in regards bag_path optimization

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

---------

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
(cherry picked from commit 66af399)

# Conflicts:
#	rosbag2_py/test/test_transport.py
@mergify mergify bot mentioned this pull request Jun 4, 2024
Merged
mergify bot pushed a commit that referenced this pull request Jun 4, 2024
@MichaelOrlov @mergify
Fix for false negative tests in rosbag2_py (#1592)
ec88f13 
* Fix for false negative tests in rosbag2_py

-  wait_for(condition: Callable, timout) was incorrectly returning True
after the first iteration even if condition was false.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

* Address review comments in regards bag_path optimization

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

---------

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
(cherry picked from commit 66af399)

# Conflicts:
#	rosbag2_py/test/test_transport.py
@mergify mergify bot mentioned this pull request Jun 4, 2024
Merged
MichaelOrlov added a commit that referenced this pull request Jun 4, 2024
@mergify @MichaelOrlov
[humble] Fix for false negative tests in rosbag2_py (backport #1592) (#…
a79568a 
…1689)

* Fix for false negative tests in rosbag2_py (#1592)

* Fix for false negative tests in rosbag2_py

-  wait_for(condition: Callable, timout) was incorrectly returning True
after the first iteration even if condition was false.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

* Address review comments in regards bag_path optimization

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

---------

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
(cherry picked from commit 66af399)

# Conflicts:
#	rosbag2_py/test/test_transport.py

* Resolve merge conflicts

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

---------

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov added a commit that referenced this pull request Jun 4, 2024
@mergify @MichaelOrlov
[iron] Fix for false negative tests in rosbag2_py (backport #1592) (#…
6050648 
…1688)

* Fix for false negative tests in rosbag2_py (#1592)

* Fix for false negative tests in rosbag2_py

-  wait_for(condition: Callable, timout) was incorrectly returning True
after the first iteration even if condition was false.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

* Address review comments in regards bag_path optimization

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

---------

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
(cherry picked from commit 66af399)

# Conflicts:
#	rosbag2_py/test/test_transport.py

* Resolve merge conflicts

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

---------

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
This was referenced Jun 4, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@gbiggs gbiggs Awaiting requested review from gbiggs gbiggs is a code owner automatically assigned from ros2/tooling-reviewers

@jhdcs jhdcs Awaiting requested review from jhdcs jhdcs is a code owner automatically assigned from ros2/tooling-reviewers

@fujitatomoya fujitatomoya Awaiting requested review from fujitatomoya

Assignees

@MichaelOrlov MichaelOrlov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelOrlov @r7vme @clalancette