Switch rclpy to be an exec_depend in rosbag2_py. #1606
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's because there is code in _storage.cpp
that imports rclpy.duration at runtime.
In particular, see
rosbag2/rosbag2_py/src/rosbag2_py/_storage.cpp
Line 37 in 1bfe305
rosbag2/rosbag2_py/src/rosbag2_py/_storage.cpp
Line 50 in 1bfe305