Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch rclpy to be an exec_depend in rosbag2_py. #1606

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

clalancette
Copy link
Contributor

That's because there is code in _storage.cpp
that imports rclpy.duration at runtime.

In particular, see

pybind11::object Duration = pybind11::module::import("rclpy.duration").attr("Duration");
and
pybind11::object Time = pybind11::module::import("rclpy.time").attr("Time");

That's because there is code in _storage.cpp
that imports rclpy.duration at runtime.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette requested a review from a team as a code owner April 10, 2024 18:08
@clalancette clalancette requested review from MichaelOrlov and james-rms and removed request for a team April 10, 2024 18:08
@clalancette clalancette changed the title Switch rclpy to be an exec_depend here. Switch rclpy to be an exec_depend in rosbag2_py. Apr 10, 2024
@clalancette
Copy link
Contributor Author

clalancette commented Apr 10, 2024

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Copy link
Contributor

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelOrlov
Copy link
Contributor

@clalancette It seems that the rpr job is broken. Any thoughts or estimates on when it will get back to the normal state?

@clalancette
Copy link
Contributor Author

@clalancette It seems that the rpr job is broken. Any thoughts or estimates on when it will get back to the normal state?

Unfortunately no. We are still working through issues with Ubuntu 24.04, and I don't currently have an estimate when those will be fixed.

@clalancette clalancette merged commit 6202aae into rolling Apr 11, 2024
13 of 14 checks passed
@delete-merged-branch delete-merged-branch bot deleted the clalancette/change-rosbag2-py-deps branch April 11, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants