Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update zstd lib into CMakeLists.txt #1610

Closed
wants to merge 1 commit into from
Closed

Update zstd lib into CMakeLists.txt #1610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions zstd_vendor/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ find_package(ament_cmake REQUIRED)
find_package(ament_cmake_vendor_package REQUIRED)

list(INSERT CMAKE_MODULE_PATH 0 "${CMAKE_CURRENT_SOURCE_DIR}/cmake/Modules")
# We need at least VERSION 1.4.8, version check is done in Findzstd.cmake
find_package(zstd 1.4.8 QUIET)
# We need at least VERSION 1.5.6, version check is done in Findzstd.cmake
find_package(zstd 1.5.6 QUIET)
Comment on lines +8 to +9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should vendor version 1.5.5, as that is the version that will be shipped in Ubuntu 24.04: https://packages.ubuntu.com/noble/libzstd1


ament_vendor(zstd_vendor
SATISFIED ${zstd_FOUND}
VCS_URL https://github.com/facebook/zstd.git
VCS_VERSION v1.4.8
VCS_VERSION v1.5.6
SOURCE_SUBDIR build/cmake
CMAKE_ARGS
-DZSTD_BUILD_STATIC:BOOL=OFF
Expand Down