Move repeated logic for C include prefix into common function #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same logic for stripping the end of the include prefix for services and actions was repeated in several places. This is a minor refactor moving the logic to a common place. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
to ros2/rosidl_typesupport_connext
that referenced
this pull request
Jan 22, 2020
Depends on ros2/rosidl#432 Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
CI for this and the connected PR:
|
dirk-thomas
approved these changes
Jan 22, 2020
jacobperron
added a commit
to ros2/rosidl_typesupport_connext
that referenced
this pull request
Jan 22, 2020
Depends on ros2/rosidl#432 Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same logic for stripping the end of the include prefix for services and actions was repeated in several places.
This is a minor refactor moving the logic to a common place.