Rework nested types' items introspection in C and C++ #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows direct memory access to nested types' items in C/C++ (but bool sequences) - Allows indirect memory access to nested types' items in C/C++ Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
|
Full CI:
|
hidmic
force-pushed
the
hidmic/rework-nested-types-introspection
branch
from
31146b7
to
3037a29
Compare
j-rivero
reviewed
Jan 24, 2022
...pesupport_introspection_c/include/rosidl_typesupport_introspection_c/message_introspection.h
Show resolved
Hide resolved
j-rivero
reviewed
Jan 24, 2022
...ort_introspection_cpp/include/rosidl_typesupport_introspection_cpp/message_introspection.hpp
Show resolved
Hide resolved
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
j-rivero
approved these changes
Jan 24, 2022
j-rivero
approved these changes
Jan 24, 2022
|
Full CI (after fixing linter issues):
|
|
Alright, going in! |
delete-merged-branch
bot
deleted the
hidmic/rework-nested-types-introspection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precisely what the title says. Alternative to #141. This patch:
get()andget_const()functions (fast, direct memory access) for all nested types in C/C++ (but bool sequences).fetch()andassign()functions (slow, indirect memory access) for all nested types in C/C++.