Update Quality declaration to level 1 in README for instrospection pkgs #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
clalancette
approved these changes
Feb 15, 2022
There was a problem hiding this comment.
Sigh, yes. I argued against duplicating the information in these files at all for exactly this reason, but I was overridden on that decision. I'd much rather this say "look at QUALITY_DECLARATION.md for the quality level".
That said, we don't need to do that here, so looks good to me.
gbiggs
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @emersonknapp for catching the problem. Another alternative would be to remove the Quality level in the READMEs but I left them here to be consistent with the rest of the
rosidlrepository. I quick look into how things are in other repositories (rclcpp and rcl) seems like there is no homogeneous way to deal with this.