Implement resize function for String
#806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m12watanabe1a
requested review from
adityapande-1995,
methylDragon,
quarkytale and
sloretz
as code owners
Signed-off-by: m12watanabe1a <40206149+m12watanabe1a@users.noreply.github.com>
m12watanabe1a
changed the title
resize function for Stringresize function for String
ahcorde
requested changes
Apr 29, 2024
Comment on lines
123
to
124
| * | ||
| * \param[in] n the new size of the internal buffer |
There was a problem hiding this comment.
Suggested change
| * | |
| * \param[in] n the new size of the internal buffer | |
| * | |
| * \param[ ] str ... | |
| * \param[in] n the new size of the internal buffer |
There was a problem hiding this comment.
Thank you for cheking it.
I've been added a comment for the missing parameter with the following commit.
Signed-off-by: m12watanabe1a <40206149+m12watanabe1a@users.noreply.github.com>
|
fujitatomoya
approved these changes
Apr 29, 2024
Comment on lines
146
to
147
| bool rosidl_runtime_c__String__resize( | ||
| rosidl_runtime_c__String *str, size_t n) |
There was a problem hiding this comment.
Suggested change
| bool rosidl_runtime_c__String__resize( | |
| rosidl_runtime_c__String *str, size_t n) | |
| bool | |
| rosidl_runtime_c__String__resize( | |
| rosidl_runtime_c__String *str, size_t n) |
|
@m12watanabe1a do you mind to apply the suggestion ? |
Sorry for getting late to reply and I'm fixing it. |
Signed-off-by: WATANABE Aoi <40206149+m12watanabe1a@users.noreply.github.com>
fujitatomoya
approved these changes
Apr 30, 2024
ahcorde
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed the following issue and confirmed that the test is passing.
#764