Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix too early decref of WString when converting from Python to C #117

Merged
merged 1 commit into from
Jul 13, 2020
Merged

fix too early decref of WString when converting from Python to C #117

merged 1 commit into from
Jul 13, 2020

Conversation

dirk-thomas
Copy link
Member

Fixes #104.

Windows debug builds only testing test_communication:

  • Before: Build Status
  • After: Build Status

@dirk-thomas
fix too early decref of WString when converting from Python to C
f8b5bdd 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas added the bug Something isn't working label Jul 13, 2020
@dirk-thomas dirk-thomas self-assigned this Jul 13, 2020
@dirk-thomas dirk-thomas added this to In progress in Towards Green CI via automation Jul 13, 2020
@dirk-thomas dirk-thomas added this to Proposed in Foxy Patch Release 2 via automation Jul 13, 2020
@dirk-thomas dirk-thomas added this to Needs Backport in Eloquent Patch Release 2 Jul 13, 2020
@dirk-thomas dirk-thomas added this to Needs Backport in Dashing Patch Release 8 Jul 13, 2020
@dirk-thomas dirk-thomas moved this from Proposed to Needs backport in Foxy Patch Release 2 Jul 13, 2020
ivanpauno
ivanpauno approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I've left two comments that don't need to be addressed, and a question to confirm that I'm understanding the PR correctly 😂.

rosidl_generator_py/resource/_msg_support.c.em Show resolved Hide resolved
rosidl_generator_py/resource/_msg_support.c.em Show resolved Hide resolved
rosidl_generator_py/resource/_msg_support.c.em Show resolved Hide resolved
@dirk-thomas dirk-thomas merged commit cd55302 into master Jul 13, 2020
Towards Green CI automation moved this from In progress to Done Jul 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/fix-decref-encoded-wstring branch July 13, 2020 19:26
@dirk-thomas dirk-thomas added this to Needs release in Rolling Ridley Jul 14, 2020
@jacobperron jacobperron removed this from Needs backport in Foxy Patch Release 2 Aug 5, 2020
@jacobperron jacobperron added this to Proposed in Foxy Patch Release 3 via automation Aug 5, 2020
@jacobperron jacobperron moved this from Proposed to Needs backport in Foxy Patch Release 3 Aug 5, 2020
@jacobperron jacobperron removed this from Needs backport in Foxy Patch Release 3 Oct 9, 2020
@jacobperron jacobperron added this to Proposed in Foxy Patch Release 4 via automation Oct 9, 2020
@jacobperron jacobperron moved this from Proposed to Needs backport in Foxy Patch Release 4 Oct 9, 2020
@jacobperron jacobperron moved this from Needs backport to Needs release in Foxy Patch Release 4 Nov 10, 2020
jacobperron pushed a commit that referenced this pull request Nov 10, 2020
@dirk-thomas @jacobperron
fix too early decref of WString when converting from Python to C (#117)
8c4fcb4 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@jacobperron jacobperron mentioned this pull request Nov 10, 2020
Merged
jacobperron pushed a commit that referenced this pull request Nov 10, 2020
@dirk-thomas @jacobperron
fix too early decref of WString when converting from Python to C (#117)
2e9dc32 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@jacobperron jacobperron mentioned this pull request Nov 10, 2020
Merged
@jacobperron jacobperron removed this from Needs Backport in Eloquent Patch Release 2 Nov 10, 2020
@jacobperron jacobperron removed this from Needs Backport in Dashing Patch Release 8 Nov 10, 2020
jacobperron added a commit that referenced this pull request Nov 10, 2020
@jacobperron @dirk-thomas
fix too early decref of WString when converting from Python to C (#117)…
f8f0ebb 
… (#121)

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

Co-authored-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
jacobperron added a commit that referenced this pull request Nov 10, 2020
@jacobperron @dirk-thomas
fix too early decref of WString when converting from Python to C (#117)…
5f349e9 
… (#120)

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

Co-authored-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@jacobperron jacobperron moved this from Needs release to Released in Foxy Patch Release 4 Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
bug Something isn't working
Projects
No open projects
Foxy Patch Release 4
Released
Rolling Ridley
Needs release
Towards Green CI
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crashes with rclpy wstring tests
2 participants
@dirk-thomas @ivanpauno