Skip to content

[dashing] fix too early decref of WString when converting from Python to C (#117) #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2020
Merged

[dashing] fix too early decref of WString when converting from Python to C (#117) #120

merged 1 commit into from
Nov 10, 2020

Conversation

jacobperron
Copy link
Member

Backport #117 to Dashing.

@dirk-thomas @jacobperron
fix too early decref of WString when converting from Python to C (#117)
8c4fcb4 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@jacobperron jacobperron self-assigned this Nov 10, 2020
@jacobperron jacobperron added the bug Something isn't working label Nov 10, 2020
@jacobperron jacobperron merged commit 5f349e9 into dashing Nov 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the jacob/dashing_backport_117 branch November 10, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz Awaiting requested review from sloretz

1 more reviewer

@claireyywang claireyywang claireyywang approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jacobperron jacobperron

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobperron @claireyywang @dirk-thomas