Switch to gz_math_vendor. #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignition is no more, long live Gazebo. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
CI with this and ros2/ros2#1537:
|
mjcarroll
approved these changes
Mar 28, 2024
|
CI:
|
ahcorde
approved these changes
Apr 1, 2024
|
@clalancette, warnings looks unrelated, anyhow feel free to merge it when you consider |
Agreed. I'm going to go ahead and merge this one and ros2/ros2#1537 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignition is no more, long live Gazebo.
@ahcorde I could use help from you in particular on testing this to make sure it still works. I'm not entirely sure what plugins
robot_link.cppis used in, nor how to test them.@azeey FYI.
This needs to be merged simultaneously with ros2/ros2#1537