Removed assimp warnings #1191
Merged
Removed assimp warnings #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
clalancette
requested changes
Apr 25, 2024
| @@ -29,6 +29,7 @@ else() | |||
| set(ASSIMP_CMAKE_FLAGS "-DCMAKE_INSTALL_LIBDIR=lib") | |||
|
|
|||
| set(ASSIMP_CXX_FLAGS "-std=c++14 ${CMAKE_CXX_FLAGS}") | |||
| set(ASSIMP_C_FLAGS "-Wno-deprecated-non-prototype ${CMAKE_C_FLAGS}") | |||
There was a problem hiding this comment.
I'm on board with suppressing this warning, but I think we should have a comment saying why we did it (so we can possibly remove it later). Something like:
# assimp version 5.3.1 still uses K&R style function prototypes, which are deprecated as of gcc 13.2 (in Ubuntu 24.04).
# Suppress the warning here for now.
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
clalancette
approved these changes
Apr 25, 2024
|
|
https://github.com/Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit e8dd485)
ahcorde
added a commit
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There many warnings on this CI job https://ci.ros2.org/view/nightly/job/nightly_linux_clang_libcxx/1868/clang-tidy/new/folder.-847954078/
This PR should fix them