Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX CVE in external libraries #961

Merged
merged 2 commits into from
May 15, 2023
Merged

FIX CVE in external libraries #961

merged 2 commits into from
May 15, 2023

Conversation

mosfet80
Copy link
Contributor

@mosfet80 mosfet80 commented Mar 23, 2023

fix CVE vulnerability in zlib https://nvd.nist.gov/vuln/detail/CVE-2022-37434
fix CVE vulnerability in freetype https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15999

Fix and improvements in zlib and freetype

fix CVE vulnerability in zlib https://nvd.nist.gov/vuln/detail/CVE-2022-37434

Fix and improvements in zlib and freetype
@mosfet80 mosfet80 requested a review from ahcorde as a code owner March 23, 2023 08:31
@mosfet80 mosfet80 changed the title Update CMakeLists.txt FIX CVE in external libraries Mar 23, 2023
mosfet80 added a commit to mosfet80/rviz that referenced this pull request Mar 23, 2023
fix CVE vulnerability in zlib https://nvd.nist.gov/vuln/detail/CVE-2022-37434 Fix and improvements in zlib and freetype
@Yadunund
Copy link
Member

Yadunund commented Apr 7, 2023

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • RHEL-9 Build Status
  • Windows Build Status

Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green! @clalancette any concerns with merging this in?

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clalancette and @Yadunund can we merge this ? we should probably run the CI again.

@clalancette
Copy link
Contributor

@clalancette and @Yadunund can we merge this ?

As elsewhere, I'd really rather have these vendored versions of the packages match what is in Ubuntu 22.04. For freetype, that looks to be version 2.11.1, and for zlib that looks to be 1.2.11 (what is already vendored here).

Are there particular CVEs that we are looking to fix with the upgrade of zlib to something newer?

@mosfet80
Copy link
Contributor Author

this patch solve a dangerous vulnerability.
CVE-2022-37434
Base Score: 9.8 CRITICAL

@clalancette
Copy link
Contributor

this patch solve a dangerous vulnerability.

Thank you. Sorry, I see that this was in the initial description as well, I missed that yesterday.

In that case, I think what we are doing here for zlib is fine. For freetype, I'd rather that we stick to the version vendored in Jammy, so please change that one back to 2.11.1. At that point I think we can go ahead with this PR.

set freetype versione to 2.11.1 (used in Jammy)
@mosfet80
Copy link
Contributor Author

@clalancette i changed the version of freetype to v.2.11.1

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit bc93b34 into ros2:rolling May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants