Add CMake lint test to sros2_cmake #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed lint errors accordingly. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added
in review
|
CI (up to
|
mjcarroll
approved these changes
Mar 8, 2019
mjcarroll
added a commit
that referenced
this pull request
Mar 8, 2019
* Correct sros2 cli test folder location (#83) * Update test folder location fixing incomplete rebase from #72 * Remove old yaml profile examples fixing incomplete rebase from #72 * add reference to schema in generated permission files (#84) Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com> * Add missing attributes to test permissions XML file Signed-off-by: Jacob Perron <jacob@openrobotics.org> * fix status print to match commands invoked Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com> * Fix bug preventing generate_policy verb from working with publishers and services Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Add CMake lint test to sros2_cmake (#90) Fixed lint errors accordingly. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Merged
There was a problem hiding this comment.
thanks @jacobperron !
I'm unsure how ament_lint_auto is meant to be used for pure cmake packages in non ament packages.
I opened #95 with an alternative approach
| configure_package_config_file(sros2_cmakeConfig.cmake.in | ||
| ${CMAKE_CURRENT_BINARY_DIR}/sros2_cmakeConfig.cmake | ||
| INSTALL_DESTINATION ${LIB_INSTALL_DIR}/sros2_cmake/cmake | ||
| find_package(ament_cmake_test REQUIRED) |
There was a problem hiding this comment.
I believe this is not necessary.
If it is, should it be listed as a dependency in the package.xml?
| if(BUILD_TESTING) | ||
| find_package(ament_lint_auto REQUIRED) | ||
| ament_lint_auto_find_test_dependencies() | ||
| ament_lint_cmake() |
There was a problem hiding this comment.
If we need to call out the test explicitly, do we need ament_lint_auto at all?
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed lint errors accordingly.