Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for QoS durability #32

Closed
wants to merge 5 commits into from
Closed

Added test for QoS durability #32

wants to merge 5 commits into from

Conversation

esteve
Copy link
Member

@esteve esteve commented Aug 20, 2015

This PR adds a test for TRANSIENT_LOCAL durability.
connects to #214

@esteve esteve added the in progress Actively being worked on (Kanban column) label Aug 20, 2015
@esteve esteve removed the in progress Actively being worked on (Kanban column) label Sep 22, 2015
@esteve esteve added the in progress Actively being worked on (Kanban column) label Oct 13, 2015
@esteve esteve self-assigned this Oct 13, 2015
@esteve esteve added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Oct 13, 2015
@esteve esteve added in progress Actively being worked on (Kanban column) and removed in review Waiting for review (Kanban column) labels Oct 14, 2015
@tfoote tfoote added ready Work is about to start (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Oct 27, 2015
@esteve esteve removed their assignment Dec 16, 2015
@esteve esteve removed the ready Work is about to start (Kanban column) label Dec 16, 2015
@mikaelarguedas mikaelarguedas self-assigned this Apr 10, 2017
@clalancette
Copy link
Contributor

@esteve Sorry we never got a chance to look at this. Since I was passing through this repository, I took the opportunity to rebase it, clean it up, and get all combinations of the tests working using the newer CMake infrastructure. Hope you don't mind. Have a look and let me know what you think.

@clalancette clalancette added the question Further information is requested label Aug 7, 2017
@mikaelarguedas
Copy link
Member

Note: Do you think we could we extend the current publisher / subscriber and test_publisher_subscriber templates rather than adding another set of talker and listener scripts? This would also allow testing different message types and custom node names / topic names that have proven to cause flaky tests when nodes from the previous tests haven't finished shutting down properly

@clalancette
Copy link
Contributor

Note: Do you think we could we extend the current publisher / subscriber and test_publisher_subscriber templates rather than adding another set of talker and listener scripts? This would also allow testing different message types and custom node names / topic names that have proven to cause flaky tests when nodes from the previous tests haven't finished shutting down properly

Hm, yeah, that's a good point. It is probably possible; let me take a quick look and see how hard it will be.

@esteve
Copy link
Member Author

esteve commented Aug 8, 2017

@clalancette

Hope you don't mind. Have a look and let me know what you think.

no problem at all! Thanks for looking into this and fleshing it out.

@mikaelarguedas
Copy link
Member

marking this as connecting to #214 and removing question label

@mikaelarguedas mikaelarguedas removed the question Further information is requested label Aug 8, 2017
@mikaelarguedas mikaelarguedas added the enhancement New feature or request label Aug 8, 2017
@jacobperron
Copy link
Member

I'm going to close this due to its age and inactivity. We still have the open issue if someone wants to revisit testing QoS combinations: #214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants