-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added test for QoS durability #32
Conversation
627ca5c
to
f49a9c5
Compare
f49a9c5
to
990f8ee
Compare
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
7bc73e8
to
ca33b59
Compare
@esteve Sorry we never got a chance to look at this. Since I was passing through this repository, I took the opportunity to rebase it, clean it up, and get all combinations of the tests working using the newer CMake infrastructure. Hope you don't mind. Have a look and let me know what you think. |
Note: Do you think we could we extend the current publisher / subscriber and test_publisher_subscriber templates rather than adding another set of talker and listener scripts? This would also allow testing different message types and custom node names / topic names that have proven to cause flaky tests when nodes from the previous tests haven't finished shutting down properly |
Hm, yeah, that's a good point. It is probably possible; let me take a quick look and see how hard it will be. |
no problem at all! Thanks for looking into this and fleshing it out. |
marking this as connecting to #214 and removing question label |
I'm going to close this due to its age and inactivity. We still have the open issue if someone wants to revisit testing QoS combinations: #214 |
This PR adds a test for TRANSIENT_LOCAL durability.
connects to #214