Skip to content

Conversation

@ouaibsky
Copy link

@ouaibsky ouaibsky commented Oct 12, 2017

according to some bean information.

My use case is simple:

  • Be able to tune the main stage according to some beans value and/or spring profile activated. (before showing the main stage)

@ouaibsky
Copy link
Author

ouaibsky commented Oct 12, 2017

I changed nothing in pom, weird that dependency download failed.
works fine behind my company proxy.
I had to do a mvn -U to download all dep.
I don't know how to trigger a travis build without pushing a new commit.

@roskenet
Copy link
Owner

Yes, don't worry about that...
It's the same as in my company: You have the spring framework milestone versions already in your company's repo.
I'll take a look asap!

@ouaibsky
Copy link
Author

Ok
I would like to propose a couple of minor enhancement.
How do you want to process:

  • Discuss within an issue then doing PR
  • propose PR directly ?

Let me know.

@ouaibsky ouaibsky mentioned this pull request Oct 13, 2017
@ouaibsky
Copy link
Author

Hi
Any news ?

  • Do u wanna me to push again ?
    Cheers
    Christophe.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 37.97% when pulling 873daf1 on societe-generale:master into 55885ce on roskenet:master.

@ouaibsky
Copy link
Author

Looks good
Any concerns to merge ?
Chris

@roskenet
Copy link
Owner

Hey Chris...
Sorry for waiting the long delay - but had a lot of different stuff to do.
Thanks for your contribution!

@roskenet roskenet merged commit 70d091d into roskenet:master Oct 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants