Skip to content

Conversation

@ouaibsky
Copy link

@ouaibsky ouaibsky commented Nov 3, 2017

Main idea is

  • to reuse stage icons between splash and main stage when possible
  • tune splash to handle image with background transparency

If second commit is (transparency) is KO for u, I can remove.
Chris.

…rom properties.

unfortunately we can not reuse from properties because at splast time, spring ctx is not yet available.
Looks more appropriate and make sure image with transparent background are well managed.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 38.182% when pulling 52edf6d on societe-generale:feat/reuse_icon_for_splashscreen into a791e12 on roskenet:master.

@ouaibsky
Copy link
Author

ouaibsky commented Nov 3, 2017

Hi,
I tried to add UT for AbstractJavaFxApplicationSupport but looks like it's not obvious to check code that is supposed to run inside JavaFXhread.

Maybe it would be nice to add libraries like https://github.com/TestFX/TestFX
Any help is welcome (for instance to test AbstractJavaFxApplicationSupport#loadDefaultIcons

@coveralls
Copy link

Coverage Status

Coverage increased (+15.6%) to 54.545% when pulling 472834e on societe-generale:feat/reuse_icon_for_splashscreen into a791e12 on roskenet:master.

@ouaibsky ouaibsky mentioned this pull request Nov 6, 2017
@roskenet roskenet merged commit b432d17 into roskenet:master Nov 7, 2017
@roskenet
Copy link
Owner

roskenet commented Nov 7, 2017

Thank you very much for your contribution!
I once started a naive testing approach with this:
https://github.com/roskenet/springboot-javafx-test

Not really usable nor in any good shape...
So any effort in making JavaFX apps testable is highly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants