Apple sign in rownd

[mfmurray]

1. Added a requestAppleSignIn method in the Rownd class
2. Added apple sign in flow to the AppleSignUpCoordinator
   • Once a user completes apple sign in, the jwtToken gets sent to Rown hub/auth, after that the email, first name, last name gets saved to the Rownd User
3. Still need to determine a solution for when Rownd might fail getting the access token or fail to update email or names...

[mhamann]

typo assigning

[mfmurray]

updated

[mhamann]

typo successful

[mfmurray]

updated

[mhamann]

we can provide a bit better log message here to help with debugging. something like logger.error("An error occurred while signing in with Apple. Error: \String(describing: error))")

[mfmurray]

Logger has been updated

[mhamann]

Use swift convention here idToken and appId and then use the CodingKeys to translate to the proper string format.

[mfmurray]

updated

[mhamann]

Good re-use of this function! Let's rename this to be a bit more generic like func fetchToken()

Then, rather than using two token arguments here, we can overload this function in the following way.

The first function overload would look something like this and handle the refresh token case:

static func fetchToken(refreshToken: String, withCompletion completion: @escaping (AuthState?) -> Void) -> Void {
  let tokenRequest = TokenRequest(refreshToken: refreshToken)
  return fetchToken(tokenRequest: tokenRequest, withCompletion: completion)
}

The second function overload would be something like this, handling the Apple ID token case:

static func fetchToken(idToken: String, withCompletion completion: @escaping (AuthState?) -> Void) -> Void {
  let tokenRequest = TokenRequest(idToken: idToken, appId: store.state.appConfig.id)
  return fetchToken(tokenRequest: tokenRequest, withCompletion: completion)
}

Now, we can pack all of our shared business logic into the final function overload:

static func fetchToken(tokenRequest: TokenRequest, withCompletion completion: @escaping (AuthState?) -> Void) -> Void {
    var resource = TokenResource()
    resource.headers = [
        "Content-Type": "application/json"
    ]
    let request = APIRequest(resource: resource)
    let encoder = JSONEncoder()
    var body: Data?
    do {
      body = try encoder.encode(tokenRequest)
    } catch {
      return completion(nil)
    }

    request.execute(...)
}

So, then the Apple ID code can call the function expecting an ID token, the refresh flow can call this function with that type of token. This makes the internal API contract more explicit and easier to test.

[mfmurray]

Wow really like this logic! So cool you can call the same function and get different logic depending on the parameters

[mhamann]

I think it might be preferable to have a function that looks more like: requestSignIn(with: RowndSignInHint)

Then, the sign-in hint is an enum:

enum RowndSignInHint {
  case appleId
}

The function body would look something like:

public static func requestSignIn(with: RowndSignInHint) {
  switch(with) {
  case .appleId:
    appleSignUpCoordinator?.didTapButton()
  default:
    requestSignIn()
  }
}

If a customer wants the standard sign-in process, they simply call requestSignIn() as before, but if they want to hint that a particular method should be used, they can call requestSignIn(with: .appleId) and Rownd should honor that request if possible.

There may be times when we can't honor it (e.g., if Sign in with Apple isn't enabled within the customer's Rownd app), so a future update might add that logic to fallback to the default in such an event.

[mfmurray]

Updated

[mhamann]

This looks good! I left a few comments where we can streamline the code a bit.

In this PR or a follow-on, we should update the docs to reflect the new APIs as well as what code a customer might need to put into their app to get Sign in with Apple working.

[mfmurray]

This looks good! I left a few comments where we can streamline the code a bit.

In this PR or a follow-on, we should update the docs to reflect the new APIs as well as what code a customer might need to put into their app to get Sign in with Apple working.

Would you want me to work on updated the docs this week? Or just wait for Product Meeting?

[mhamann]

You can just call Storage.store?.set(encoded, forKey: appleSignInDataKey) to use the SDK's common storage manager (see Models/Storage.swift)