#175 count frames at SceneManager #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove accessing to $gameSystem by Scene_Base.
krmbn0576
reviewed
Aug 26, 2018
js/rpg_objects/Game_System.js
Outdated
| Game_System.prototype.frameCount = function() { | ||
| return this._frameCount; | ||
| return SceneManager.frameCount(); | ||
| }; |
Collaborator
There was a problem hiding this comment.
this function may no longer be required, because it does not originally exist ;-)
Contributor
Author
There was a problem hiding this comment.
All right, I will remove this.
krmbn0576
reviewed
Aug 26, 2018
| Game_System.prototype.onAfterLoad = function() { | ||
| if (!this._frameCount) { | ||
| this._frameCount = this._framesOnSave; | ||
| } |
Collaborator
There was a problem hiding this comment.
Please, do not erase this for save data compatibility.
If this does not exist, SceneManager.setFrameCount(undefined) may occur. 😢
Contributor
Author
There was a problem hiding this comment.
I think that to raise the complexity of scripts for save data compatibility is not good. Though I respect your policy.
Collaborator
|
Do not forget to reset |
krmbn0576
reviewed
Aug 26, 2018
Collaborator
krmbn0576
left a comment
krmbn0576
left a comment
There was a problem hiding this comment.
Thank you for PR!
Would you reflect my reviews before merging?
On after load, if scene frame count is undefined, it is initialized by graphics frame count.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove accessing to $gameSystem by Scene_Base.