Added docs to Scene_Base #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added documentations to the Scene_Base class.
added 3 commits
April 13, 2017 23:08
Updated the jsdoc for the initialize for remove the constructor tags since it's provoking a bug to the jsdoc generations or intelisenses. The Also added "@instance" to method for tell the system it's not a static class.
ghost
approved these changes
May 12, 2017
|
We'll remove version info, because It is need in _header.js only. Is it ok? |
|
wether => whether? |
Author
|
@liply Sure! I am sorry I forgot to answer was busy with stuff! as for the Whether sorry it's was a misspelling of myself do you want me to fix it? |
|
could you fix it? |
Removed the Header and corrected the misspelling error
Author
|
@liply : Sure! |
krmbn0576
reviewed
May 16, 2017
js/rpg_scenes/Scene_Base.js
Outdated
| Scene_Base.prototype.update = function() { | ||
| this.updateFade(); | ||
| this.updateChildren(); | ||
| AudioManager.checkErrors(); |
Collaborator
There was a problem hiding this comment.
I removed this line before.
Could you remove?
Author
There was a problem hiding this comment.
Sure I guess my version was a little outdated!
Removed AudioManager.checkErrors();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added documentations to the Scene_Base class.