Closed
Conversation
As proof of concept.
Restore explicit checking for success of system calls as in version 5 of podlators. This is needed because podlators is bundled into the Perl core distribution where it is handled in the build process at a point where some of autodie's prerequisites are not yet built. Provide updated entry in Changes. See discussion in rra#32 and Perl/perl5#22395. Before committing, please 's{6\.0\.99}{6.0.CORRECTVERSION}g' throughout.
Grinnz
reviewed
Jul 12, 2024
| } | ||
| } | ||
| close($fh); | ||
| die "$0: cannot find version in lib/Pod/Man.pm\n"; |
There was a problem hiding this comment.
This seems like it is supposed to unconditionally die if this line is reached, so this die shouldn't be removed.
Owner
|
Thanks, I'll try to get a release out tonight with these fixes. |
Owner
|
Thanks, I have applied a version of this patch and released v6.0.1 with this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #32. As I didn't want to pre-empt your use of
v6.0.1, I arbitrarily used6.0.99throughout. Please replace as needed. Also, the perl sync-with-cpan program now checks the Changes file to make sure there's an updated entry; please change the content I provided there as needed. Thanks.