Skip to content

Commit 003f9db

Browse files
committed
adjust failing markers for list tests
1 parent 5b18683 commit 003f9db

File tree

3 files changed

+26
-0
lines changed

3 files changed

+26
-0
lines changed

Lib/test/list_tests.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
Tests common to list and UserList.UserList
33
"""
44

5+
import unittest
56
import sys
67
import os
78
from functools import cmp_to_key
@@ -303,6 +304,8 @@ def test_pop(self):
303304
self.assertRaises(TypeError, a.pop, 42, 42)
304305
a = self.type2test([0, 10, 20, 30, 40])
305306

307+
# TODO: RUSTPYTHON
308+
@unittest.expectedFailure
306309
def test_remove(self):
307310
a = self.type2test([0, 0, 1])
308311
a.remove(1)
@@ -362,6 +365,8 @@ def __eq__(self, other):
362365
# verify that original order and values are retained.
363366
self.assertIs(x, y)
364367

368+
# TODO: RUSTPYTHON
369+
@unittest.expectedFailure
365370
def test_index(self):
366371
super().test_index()
367372
a = self.type2test([-2, -1, 0, 0, 1, 2])

Lib/test/test_list.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@ class L(list): pass
164164
with self.assertRaises(TypeError):
165165
(3,) + L([1,2])
166166

167+
@unittest.skip("TODO: RUSTPYTHON; hang")
167168
def test_equal_operator_modifying_operand(self):
168169
# test fix for seg fault reported in bpo-38588 part 2.
169170
class X:
@@ -197,6 +198,7 @@ def test_preallocation(self):
197198
self.assertEqual(iter_size, sys.getsizeof(list([0] * 10)))
198199
self.assertEqual(iter_size, sys.getsizeof(list(range(10))))
199200

201+
@unittest.skip("TODO: RUSTPYTHON; hang")
200202
def test_count_index_remove_crashes(self):
201203
# bpo-38610: The count(), index(), and remove() methods were not
202204
# holding strong references to list elements while calling
@@ -229,6 +231,15 @@ def __eq__(self, other):
229231
lst = [X(), X()]
230232
X() in lst
231233

234+
# TODO: RUSTPYTHON
235+
@unittest.expectedFailure
236+
def test_count(self): # XXX: RUSTPYTHON; the method also need to be removed when done
237+
super().test_count()
238+
239+
# TODO: RUSTPYTHON
240+
@unittest.expectedFailure
241+
def test_contains_fake(self): # XXX: RUSTPYTHON; the method also need to be removed when done
242+
super().test_contains_fake()
232243

233244
if __name__ == "__main__":
234245
unittest.main()

Lib/test/test_userlist.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,16 @@ class UserListTest(list_tests.CommonTest):
1111
def test_init(self):
1212
super().test_init()
1313

14+
# TODO: RUSTPYTHON
15+
@unittest.expectedFailure
16+
def test_contains_fake(self): # XXX: RUSTPYTHON; the method also need to be removed when done
17+
super().test_contains_fake()
18+
19+
# TODO: RUSTPYTHON
20+
@unittest.expectedFailure
21+
def test_count(self): # XXX: RUSTPYTHON; the method also need to be removed when done
22+
super().test_count()
23+
1424
# TODO: RUSTPYTHON, parent method is marked but this version passes
1525
import sys
1626
@unittest.skipIf(sys.platform == "win32", "TODO: RUSTPYTHON, unexpectedly panics somewhere")

0 commit comments

Comments
 (0)