Skip to content

Feature/misc helpers-2 #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ig-sinicyn merged 5 commits into from
Feb 9, 2020
Merged

Feature/misc helpers-2 #102

ig-sinicyn merged 5 commits into from
Feb 9, 2020

Conversation

@ig-sinicyn
Copy link
Contributor

@ig-sinicyn ig-sinicyn commented Feb 8, 2020 •
edited
Loading

  • Code.CanBeCanceled() assertion. Useful for methods that require valid cancellation token.
  • WaitForCancellationAsync() extension method. Safely waits for cancellation token without throwing an OperationCanceledException.
  • TimeoutHelper. By convention, all FW methods accepts only one special value for infinite timeout: Timeout.InfiniteTimespan (-1 ms). Methods in TimespanHelper allows to replace negative (or default) values with this special value and to apply upper limit for timeout values.
  • WithTimeout() methods. Allows to await for task with timeout. RunWiithTimeout() adds cancellation of running task on timeout.

@ig-sinicyn ig-sinicyn force-pushed the feature/with-timeout branch from 311b240 to 0af5119 Compare February 8, 2020 21:04
@ig-sinicyn ig-sinicyn force-pushed the feature/with-timeout branch from 2aa1b30 to e6069b8 Compare February 8, 2020 21:10
@ig-sinicyn
+ Code.CanBeCanceled() assertion
b0772ee 
+ WaitForCancellationAsync() extension method
+ TimeoutHelper
+ WithTimeout() methods
@ig-sinicyn
Fixes on review
c109eb1
@ig-sinicyn
Move cancellation-related methods in single file
7413342
@ig-sinicyn
Fix tests
9917950
@ig-sinicyn ig-sinicyn force-pushed the feature/with-timeout branch from 8515a70 to 9917950 Compare February 9, 2020 12:17
@ig-sinicyn ig-sinicyn merged commit 6c02259 into master Feb 9, 2020
@ig-sinicyn ig-sinicyn deleted the feature/with-timeout branch February 9, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewvk andrewvk andrewvk approved these changes

Assignees

@andrewvk andrewvk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ig-sinicyn @andrewvk