Skip to content

Remove specs testing valid_table_name for database link #1706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2018
Merged

Remove specs testing valid_table_name for database link #1706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions spec/active_record/connection_adapters/oracle_enhanced/quoting_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,6 @@ class ::TestReservedWord < ActiveRecord::Base; end
expect(@adapter.valid_table_name?(("a" * 31) + ".validname")).to be_falsey
end

it "should not be valid for database links > 128 characters" do
expect(@adapter.valid_table_name?("name@" + "a" * 129)).to be_falsey
end

it "should not be valid for names that do not begin with alphabetic characters" do
expect(@adapter.valid_table_name?("1abc")).to be_falsey
expect(@adapter.valid_table_name?("_abc")).to be_falsey
Expand Down