modules don't directly depend on core

[yschimke]

http://central.maven.org/maven2/io/rsocket/rsocket-transport-netty/0.11.0/rsocket-transport-netty-0.11.0.pom

Clients need to bring in both dependencies. Is this deliberate?

[mostroverkhov]

@yschimke module in question has implementation dependency on core. More interesting thing is reactor-netty is api dependency, so likely it's typo - has to be vice versa, as transports themselves can be used without reactor-netty on compile classpath

[mostroverkhov]

Apparently parent module has to be published aswell

[nebhale]

I’ll chase this down today.

[nebhale]

@yschimke and @mostroverkhov Just want to make crystal clear for myself. When including a transport, you'd like it to express the dependency on core as a Maven <scope>compile</scope> dependency? The split between api/implementation in the new java-library Gradle plugin would lead us to that dependency being <scope>runtime</scope> but I'm pretty sure that's not what Maven users are really looking for.

[mostroverkhov]

@nebhale I prefer core as compile dependency. But for e.g. netty-transport it's better to have runtime dependency on reactor-netty, because said transport can be instantiated without reactor-netty on compile classpath

[nebhale]

Agreed on the latter. Artisinally handcrafting some free range POMs now.

[nebhale]

@mostroverkhov I think the transport backing libraries are going to need to be compile dependencies as well. Both Netty and Aeron expose their implementing types in their APIs.

[mostroverkhov]

But also can create using these ? But given that rsocket-core is built on reactor and uses some bits of netty (netty-buffer), there is indeed no big reason to have reactor-netty as runtime dependency.

[yschimke]

We should probably get the gradle ones right first. You can’t use a transport with core, it is part of their public API so gradle api instead of implementation in probably right.

[nebhale]

I'll attach this to the PR as well, but here's a sample of the POMs as they are created now.

[nebhale]

Snapshots with the new POMs should now be available for testing.

[nebhale]

@yschimke pending your review the last couple of releases that have gone out, should solve this issue.