How to limit retries for resume

[joshiste]

I wanted to limit the number of retries for resuming a connection.
I tried with this ResumeStrategy, but somehow it keeps reconnecting over and over again.
Can you help me?

public class MaxRetryResumeStrategy implements ResumeStrategy {
    private final ResumeStrategy resumeStrategy;
    private final AtomicLong retries;

    public MaxRetryResumeStrategy(long retries, ResumeStrategy resumeStrategy) {
        this.resumeStrategy = resumeStrategy;
        this.retries = new AtomicLong(retries);
    }

    @Override
    public Publisher<?> apply(ClientResume clientResume, Throwable e) {
        if (this.retries.getAndDecrement() > 0) {
            return Mono.from(this.resumeStrategy.apply(clientResume, e)).doOnNext(v -> System.out.println("Disconnected. Trying to resume connection..."));
        }
        return Mono.error(new RetryExhaustedException(e));
    }
}

[OlegDokuka]

I suspect you do something like the following;

RSocketFactory
.connect()
.resumeStrategy(() -> new MaxRetryResumeStrategy())
...

Unfortunately, I spotted a design flaw, so on every error in the connection will supply a new instance of the ResumeStrategy strategy. Therefore, your counter will be recreated after every successful resumption.

As of now, I can recommend you to do something like the following in order to implement desired behavior:

ResumeStrategy  strategy = new MaxRetryResumeStrategy()
RSocketFactory
.connect()
.resumeStrategy(() -> strategy)
...

[yschimke]

Valid workaround provided above.