Fix bug in FairLeaseGovernor #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
***Problem*** There is a bug in FairLeaseGovernor, the number of ticket per Responder is never decreased. ***Solution*** Fix the bug, add two unit-tests.
stevegury
added a commit
that referenced
this pull request
Jul 14, 2016
I had written this test for PR #147, but failed to add it.
robertroeser
pushed a commit
that referenced
this pull request
Jul 14, 2016
I had written this test for PR #147, but failed to add it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_Problem_
There is a bug in FairLeaseGovernor, the number of ticket per Responder is
never decreased.
_Solution_
Fix the bug (straightforward).
Also, add two unit-tests and improve the constructor.