Skip to content

Correct call to RemoteSender - streamId and initialRemoteRequested #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 2, 2017
Merged

Correct call to RemoteSender - streamId and initialRemoteRequested #210

merged 3 commits into from
Jan 2, 2017

Conversation

@yschimke
Copy link
Member

@yschimke yschimke commented Dec 28, 2016 •
edited
Loading

Seems like a typo

Two constructors are

public RemoteSender(Publisher<Frame> originalSource, Runnable cleanup, int streamId,  int initialRemoteRequested) {    
public RemoteSender(Publisher<Frame> originalSource, Runnable cleanup, int streamId) {

@yschimke yschimke changed the title use stream id Correct call to RemoteSender - streamId and initialRemoteRequested Dec 28, 2016
@yschimke yschimke mentioned this pull request Dec 28, 2016
Closed
@NiteshKant
Copy link
Contributor

NiteshKant commented Jan 2, 2017

Thanks @yschimke
You are correct, it is a typo and it did not help that the unit test is ignored. I will do another PR to enable that test and probably unit tests for examples.

@NiteshKant NiteshKant merged commit 4ec6edb into rsocket:0.5.x Jan 2, 2017
@yschimke yschimke deleted the use_stream_id branch May 6, 2017 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@NiteshKant NiteshKant NiteshKant approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yschimke @NiteshKant