StreamIdSupplier returns 1,3,5... or 2,4,6...

[yschimke]

No description provided.

[NiteshKant]

@yschimke I replied with my thoughts on issue #212

I think semantically we should stick to isValid() doing what it does today but initializing the supplier with -1 and 0 makes sense. Can you revert the isValid() change?

Also, I think this class should be pkg-private and isValid() should perhaps be named isBeforeCurrent() (or some better name)? If you want you can make those changes too 😄

[NiteshKant]

Thanks @yschimke ! I will pull this in once you address my comments.

[yschimke]

So I don't think I should fully revert the isValid changes, since I still think its flipped logically. For an unknown stream id, I still think you only want to log when the stream id is negative or greater than the last issued.

Also the class is used outside the package so I can't make the other change without refactoring.

[NiteshKant]

Also the class is used outside the package so I can't make the other change without refactoring.

Duh, I didn't notice the outside package usages, sorry about that.

Thanks @yschimke !