Fix Reference Count Leak #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, there were a couple of frames that converted Strings to ByteBufs automatically as part of construction. Those frames though, retained any ByteBufs passed into them so that they could be released by the creators as necessary. Since the automatic construction was not doing this release on the String-based ByteBufs, there was a minor leak of references. This change updates those locations to release the String-based ByteBufs and accurately account for their retention and release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there were a couple of frames that converted
Strings toByteBufs automatically as part of construction. Those frames though, retained anyByteBufs passed into them so that they could be released by the creators as necessary. Since the automatic construction was not doing this release on theString-basedByteBufs, there was a minor leak of references. This change updates those locations to release theString-basedByteBufs and accurately account for their retention and release.