Fix current and future streams not terminating after connection dispose #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnection dispose Signed-off-by: Maksym Ostroverkhov <m.ostroverkhov@gmail.com>
mostroverkhov
force-pushed
the
maos/fix/requester-lifecycle
branch
from
f9ba5a1 to
f169014
Compare
yschimke
reviewed
Oct 28, 2018
|
|
||
| StepVerifier.create(interaction.apply(rSocket)) | ||
| .expectError(ClosedChannelException.class) | ||
| .verify(Duration.ofSeconds(5)); |
Member
There was a problem hiding this comment.
Not specific to this PR: Are these tests "wall clock" slow? Should we tag someway to run in CI, but not in normal developer builds?
Member
Author
There was a problem hiding this comment.
Yes, this will be great improvement for local builds - will do that in follow-up. Also I was thinking about VirtualTimeScheduler, but eventually preferred approach with no magic in It as this way tests look less fragile
yschimke
approved these changes
Oct 28, 2018
Member
yschimke
left a comment
yschimke
left a comment
There was a problem hiding this comment.
Nice, this bug explains what I was seeing when testing changes in the rsocket-cli project. The change also seems like a nice cleanup.
kbahr
pushed a commit
that referenced
this pull request
Nov 2, 2018
…nnection dispose (#541) Signed-off-by: Maksym Ostroverkhov <m.ostroverkhov@gmail.com> Signed-off-by: Kyle Bahr <kyle@netifi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #468 , likely relates to #540