loadbalancer reconnects when downstream connection goes away #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This is a tough review, 2 failing tests in CI as well. I'll let you work through those but generally give you a shipit then as I think active use of this from 1.0.x branch will really help. I can add support in rsocket-cli and help test that way. I wonder whether this sort of library code (Aperture load balancer) can eventually be owned outside of RSocket? Is there a natural home for distributed systems algos like this? |
robertroeser
force-pushed
the
loadbalancer
branch
from
a3ae9bc to
1a7eb42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue #540 where load balancer does not reconnect.