Replace usage of RxJava2 with RxJava1 and RxReactiveStreams. #96
Conversation
#### Problem Tests in reactivesocket-core were using RxJava2 with a DP release. RxJava2 is currently not stable. #### Solution Moved to RxJava1 with RxReactiveStreams. When RxJava2 becomes stable, we can see whether we need to use it again.
|
ugh |
|
@benjchristensen this is just for unit tests. |
NiteshKant
changed the title
|
Yes I know. That's why I chose v2 as it wasn't production critical but allowed cleaner code. |
NiteshKant
changed the title
|
Modified the description to better depict the change. @benjchristensen @stevegury if we aren't ok with this, lets close it. |
|
There was tons of progress in RxJava 2 recently, my hope is that it will be usable sooner than I'd have expected. |
|
Even until RxJava 2 matures, I didn't find any issues while writing this code originally with just using the snapshot it currently uses. Since ReactiveSocket is all about ReactiveStreams, it was incredibly annoying always going to and from RxJava v1 Observables, and made debugging difficult as it was transformed so many times. |
|
Ok, closing the PR. Thanks guys for the feedback! |
Fixes rsocket#94 (Protocol Status) As discussed in the issue, this change specifies a status of the protocol as draft. This also elaborates on the versioning scheme used for the protocol and how to specify the same in the SETUP frame.
3 participants
Problem
Tests in reactivesocket-core were using RxJava2 with a DP release. RxJava2 is currently not stable.
Solution
Moved to RxJava1 with RxReactiveStreams. When RxJava2 becomes stable, we can see whether we need to use it again.