Kotlin/Native support #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
No review - but this is epic! |
Member
|
What does the integration story look like? e.g. is this a usable API for Swift or C++? |
Member
Author
|
Not sure, that it will be easy to use it there because of suspend functions, but it possible, you can read it here:
|
whyoleg
force-pushed
the
enhancement/native-support
branch
2 times, most recently
from
f7e0943 to
2ea6f4a
Compare
Member
Author
|
PR is ready for review, but some changes in tests running on CI will land soon. As for now, some tests are running too long on CI |
yschimke
reviewed
Oct 3, 2020
|
|
||
| suspend fun main() { | ||
| val api = connectToApi("Yuri") | ||
| val api = connectToApiUsingWS("Yuri") |
Member
Author
There was a problem hiding this comment.
hah, yes, just first name which comes in mind after mine :)
yschimke
approved these changes
Oct 3, 2020
Member
yschimke
left a comment
yschimke
left a comment
There was a problem hiding this comment.
Review didn't seem too bad, mainly
- build setup changes
- TCP duplex connection using supported channels etc.
- IntMap rewrite
whyoleg
force-pushed
the
task/update-versions
branch
from
654d043 to
18994d6
Compare
whyoleg
force-pushed
the
enhancement/native-support
branch
from
28ef408 to
561fa9b
Compare
Reworked TCP implementation Multiplatform Synchronized IntMap implementation
whyoleg
force-pushed
the
enhancement/native-support
branch
from
561fa9b to
03af77c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IntMapimplementation based on NettyIntObjectHashMap- on K/N it uses atomics to support modification, even if it's freezed. Implementation is synchronized, so it's possible to use it concurrently.Should work with WS on K/N when ktor will support it (may be in 1.5.0).
Tests for almost all targets are running ~ 1 hour, except for tvos and watchos (up to 3 hours), where new K/N allocator isn't supported (yet?).