Setup connection simplest spec #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyoleg
reviewed
May 1, 2020
Member
whyoleg
left a comment
whyoleg
left a comment
There was a problem hiding this comment.
minor kotlin style related things
| val payload: Payload? | ||
| ) : Frame<SetupFlags>(FrameType.SETUP) { | ||
|
|
||
| constructor( |
Member
There was a problem hiding this comment.
null can be used as default parameter in primary constructor
| writeByte(dataMimeType.length.toInt()) | ||
| writeUtf8(dataMimeType.text) | ||
| payload.metadata?.length?.let(this::writeLength) | ||
| if (metadataMimeType != null) { |
Member
There was a problem hiding this comment.
As I remember mime types are required
so, need to write at least one byte with 0 value
Collaborator
Author
There was a problem hiding this comment.
@OlegDokuka I've not found if mime type is required or not in RSocket spec.
My question is should spec says explicitly is mime type required during connection establishment?
tck-spec/build.gradle
Outdated
| implementation("org.spekframework.spek2:spek-dsl-jvm:$spek_version") | ||
| testRuntimeOnly("org.spekframework.spek2:spek-runner-junit5:$spek_version") | ||
| testRuntimeOnly("org.jetbrains.kotlin:kotlin-reflect:$kotlin_version") | ||
| testImplementation("io.cucumber:cucumber-java:5.6.0") |
Member
There was a problem hiding this comment.
with kotlin, better to use cucumber-java8 with lambda syntax
| } | ||
|
|
||
| class Server(private val port: Int) { | ||
| @Throws(Exception::class) |
Member
There was a problem hiding this comment.
Throws annotation isn't needed, if you not use both kotlin and java in one project
| private val initializer = ServerChannelInitializer() | ||
| private lateinit var server: Server | ||
| private lateinit var expected: SetupFrame | ||
| private lateinit var actual: SetupFrame |
alex-dukhno
force-pushed
the
setup-connection-simplest-spec
branch
from
2a1fa2f to
022e187
Compare
alex-dukhno
force-pushed
the
setup-connection-simplest-spec
branch
from
8bea67f to
fc06ba3
Compare
alex-dukhno
force-pushed
the
setup-connection-simplest-spec
branch
2 times, most recently
from
259fb1b to
6be3530
Compare
alex-dukhno
force-pushed
the
setup-connection-simplest-spec
branch
from
6be3530 to
08a599a
Compare
This was referenced Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.