This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Alias example group #1255
Merged
Alias example group #1255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Conflicts: lib/rspec/core/example_group.rb
We've occasionally received bug reports related to users having objects that redefine `send` (e.g. `Email#send`), and using `__send__` is best to avoid those problems. Many of the receivers of `__send__` here are objects we own and that do not (and never will) redefine `send`; however, for consistency, it's good to standardize on `__send__`. That way, we're less likely to forget it in the future for a case where it does matter.
This already worked but wasn't covered by a test.
- Cover all the edge cases. - Use a subprocess for global config changes. - No need to use a separate example group per method. It adds to the runtime of the test suite with no benefit.
Before, they were not exposed globally if the config option was already set.
- No need to use send. - Extract change_global_dsl helper method.
|
Thanks @myronmarston for taking over! |
- Make it a predicate w/ a question mark. - Make it actually indicate if the DSL is exposed globally.
We don't need to expose it at the top level, and it's best to cut down on what's exposed.
|
OK, I think this is ready to merge. @michihuber / @JonRowe -- care to review what I've done on top of #1236? |
|
Anyone want to review this? |
There was a problem hiding this comment.
This doesn't "prove" the :detailed => true part of the alias, do we care? Perhaps we could assert on the metadata?
Scratch that I see you're using tags.
There was a problem hiding this comment.
Honestly, I'm not super happy with this cucumber example. Got a better idea?
|
Apart from my white space niggle, LGTM :P |
"it are" is terrible English.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #1236. It's @michihuber's work plus the start of fixes I've applied based on mine and @JonRowe's feedback on that PR. This supercedes that PR.