This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Named subject can be referred from an inside subject block #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example:
describe "list" do
subject(:list) { [1,2,3] }
describe 'first' do
subject(:first_element) { list.first }
it { should eq(1) }
end
end
With the previous implementation, this fails with "stack level too deep".
This error is not obvious and irritating to me.
I believe this behaviour is more natural.
|
I think this failure has nothing to do with my patch. |
|
+1 |
1 similar comment
|
+1 |
lib/rspec/core/subject.rb
Outdated
There was a problem hiding this comment.
How about subject { send name }?
|
@dchelimsky Thanks for good advice. Fixed. |
dchelimsky
added a commit
that referenced
this pull request
Sep 1, 2012
Named subject can be referred from an inside subject block in a nested group
|
+1 |
|
Aha, thx this really helped 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
With the previous implementation, this fails with "stack level too deep".
This error is not obvious and irritating to me.
I believe this behaviour is more natural.