Include helper methods defined in controllers in the view object in

ViewExampleGroup

- based on gist from Wincent Colaiuta <win@wincent.com>
- Closes #119.

Author: dchelimsky

features/view_specs/view_spec.feature

@@ -152,3 +152,34 @@ Feature: view spec
       """
     When I run "rspec spec/views"
     Then the output should contain "1 example, 0 failures"
+
+  Scenario: spec with view that accesses helper_method helpers
+    Given a file named "app/views/secrets/index.html.erb" with:
+      """
+      <%- if admin? %>
+        <h1>Secret admin area</h1>
+      <%- end %>
+      """
+    And a file named "spec/views/secrets/index.html.erb_spec.rb" with:
+      """
+      require 'spec_helper'
+
+      describe 'secrets/index.html.erb' do
+        before do
+          controller.singleton_class.class_eval do
+            protected
+              def admin?
+                true
+              end
+              helper_method :admin?
+          end
+        end
+
+        it 'checks for admin access' do
+          render
+          rendered.should contain('Secret admin area')
+        end
+      end
+      """
+    When I run "rspec spec/views/secrets"
+    Then the output should contain "1 example, 0 failures"

lib/rspec/rails/example/view_example_group.rb

@@ -102,7 +102,6 @@ def template
         view
       end
 
-
       # Deprecated. Use +rendered+ instead.
       def response
         RSpec.deprecate("response", "rendered")
@@ -118,13 +117,21 @@ def _default_file_to_render
       def _controller_path
         _default_file_to_render.split("/")[0..-2].join("/")
       end
+
+      def _include_controller_helpers
+        helpers = controller._helpers
+        view.singleton_class.class_eval do
+          include helpers unless included_modules.include?(helpers)
+        end
+      end
     end
 
     included do
       metadata[:type] = :view
       helper *_default_helpers
 
       before do
+        _include_controller_helpers
         controller.controller_path = _controller_path
         # this won't be necessary if/when
         # https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/4903

spec/rspec/rails/example/view_example_group_spec.rb

@@ -122,10 +122,18 @@ def _assigns
     end
 
     describe '#params' do
-      include ViewExampleGroup
+      let(:view_spec) do
+        Class.new do
+          include ViewExampleGroup::InstanceMethods
+          def controller
+            @controller ||= Object.new
+          end
+        end.new
+      end
+
       it 'delegates to the controller' do
-        controller.should_receive(:params).and_return({})
-        params[:foo] = 1
+        view_spec.controller.should_receive(:params).and_return({})
+        view_spec.params[:foo] = 1
       end
     end