Incorporate rspec-core's project initialization.

The Rails centric helper is now `rails_helper`. Leverage the standard
RSpec configuration for creating basic configurations for `.rspec` and
`spec_helper`. This also keeps us in-sync with any future changes.

- Fix #1029

Author: cupakromer

features/directory_structure.feature

@@ -110,6 +110,7 @@ Feature: Directory Structure
       │   ├── books_spec.rb
       ├── routing
       │   └── books_routing_spec.rb
+      ├── spec_helper.rb
       └── tasks
       │   ├── irc_spec.rb
       └── views
@@ -133,7 +134,7 @@ Feature: Directory Structure
   Scenario: Non-rails related specs do not require `:type` metadata by default
     Given a file named "spec/ledger/entry_spec.rb" with:
       """ruby
-      require "rails_helper"
+      require "spec_helper"
 
       Entry = Struct.new(:description, :us_cents)
 

features/support/env.rb

@@ -47,7 +47,7 @@ def copy(file_or_dir)
     end
   end
 
-  ["spec/rails_helper.rb"].each do |file_or_dir|
+  ["spec/spec_helper.rb", "spec/rails_helper.rb"].each do |file_or_dir|
     write_symlink("tmp/example_app/#{file_or_dir}")
   end
 end

features/view_specs/view_spec.feature

@@ -167,7 +167,15 @@ Feature: view spec
     Then the examples should all pass
 
   Scenario: passing view spec that stubs a helper method
-    Given a file named "app/views/secrets/index.html.erb" with:
+    Given a file named "app/helpers/application_helper.rb" with:
+      """ruby
+      module ApplicationHelper
+        def admin?
+          false
+        end
+      end
+      """
+    And a file named "app/views/secrets/index.html.erb" with:
       """
       <%- if admin? %>
         <h1>Secret admin area</h1>
@@ -179,7 +187,7 @@ Feature: view spec
 
       describe 'secrets/index' do
         before do
-          view.stub(:admin?).and_return(true)
+          allow(view).to receive(:admin?).and_return(true)
         end
 
         it 'checks for admin access' do

lib/generators/rspec/install/install_generator.rb

@@ -1,3 +1,5 @@
+RSpec::Support.require_rspec_core "project_initializer"
+
 module Rspec
   module Generators
     # @private
@@ -12,14 +14,31 @@ def self.source_root
         @source_root ||= File.expand_path(File.join(File.dirname(__FILE__), 'templates'))
       end
 
-      def copy_dot_rspec
-        template '.rspec'
+      def copy_spec_files
+        Dir.mktmpdir do |dir|
+          generate_rspec_init dir
+          template File.join(dir, '.rspec'), '.rspec'
+          directory File.join(dir, 'spec'), 'spec'
+        end
       end
 
-      def copy_spec_files
-        directory 'spec'
+      def copy_rails_files
+        template 'spec/rails_helper.rb'
       end
 
+    private
+
+      def generate_rspec_init(tmpdir)
+        initializer = ::RSpec::Core::ProjectInitializer.new(
+          :destination => tmpdir,
+          :report_stream => StringIO.new
+        )
+        initializer.run
+        gsub_file File.join(tmpdir, 'spec', 'spec_helper.rb'),
+                  'rspec --init',
+                  'rails generate rspec:install',
+                  :verbose => false
+      end
     end
   end
 end

lib/generators/rspec/install/templates/.rspec

@@ -1,5 +1,6 @@
 # This file is copied to spec/ when you run 'rails generate rspec:install'
 ENV["RAILS_ENV"] ||= 'test'
+require 'spec_helper'
 require File.expand_path("../../config/environment", __FILE__)
 require 'rspec/rails'
 

lib/generators/rspec/install/templates/spec/rails_helper.rb

@@ -14,5 +14,7 @@
 
 file "app/views/things/custom_action.html.erb", "This is a template for a custom action.", {:force=>true}
 
+gsub_file 'spec/spec_helper.rb', /^=(begin|end)/, ''
+
 run('rake db:migrate')
 run('rake db:migrate RAILS_ENV=test')