New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix anonymous controller route helpers #905
Fix anonymous controller route helpers #905
Conversation
Travis is failing with:
Which leaves me baffled, as I didn't touch that file or anything I can think would affect it. |
In rspec-expectations I recently renamed that class. See rspec/rspec-expectations@6bde36e and rspec/rspec-expectations#398. Use |
@myronmarston Okay, thanks. I guess that should be a separate PR however. |
Have at it! |
@myronmarston The new I could either monkeypatch This was introduced in rspec/rspec-expectations@ec93540. |
I've got a fix in rspec/rspec-expectations#404. |
I just merged that PR so you should be good to go now :). Sorry about the regression! |
Cheers @myronmarston. |
…n an anonymous controller has been defined.
Just squashed my tests into the same commit for neatness, and to trigger Travis. |
Travis is failing on one spec that appears unrelated, as mentioned in #906 by @alindeman. |
For now, I decided simply to partially revert the commit. I'd love to have it covered by a spec, but I think we need a common way to run examples (extracted from -core?) first. |
Consider using the spec attached to this issue once you're ready. |
rspec-support could be a good home for the supporting code. I'm working on improving rspec-mocks so that no monkey patching is needed to get it to work in that fashion. |
@myronmarston I did notice that the spec was a little tricky to write. |
Continuing on from #881.
Changed
orig_routes
to@orig_routes
as it is referred to inmethod_missing
on line 138. Bug introduced in 86aea05. Added a test that fails when fix is reverted.