-
Notifications
You must be signed in to change notification settings - Fork 65
feat: Add toolbar buttons #1256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/toolbar-epic
Are you sure you want to change the base?
Conversation
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
…slib into feat/toolbar-container
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
…into feature/add-buttons
…into feature/add-buttons
| >.fa, | ||
| >.bi, | ||
| >.glyphicon { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternative, maybe we should put the icon in a <span class="toolbar-icon"> and then use this?
| >.fa, | |
| >.bi, | |
| >.glyphicon { | |
| > .toolbar-icon > * { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or if we require shiny (>= 1.11.1.9000) we could use .action-icon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way to get there is roughly:
# In this PR
usethis::use_dev_package("shiny")This adds a Remotes field to DESCRIPTION so that dev bslib uses dev shiny, plus a min version requirement on shiny.
Then after shiny v1.12.0 release, we'll update the record here in bslib.
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
Fixes #1248
Adds buttons suitable for inclusion in toolbars.
Buttons:
To-do:
Example with active/disabled button
Before click activate button:
