Allow searching for arguments by name (regardless of value)#48
Merged
rossellhayes merged 10 commits intomainfrom Oct 12, 2022
Merged
Allow searching for arguments by name (regardless of value)#48rossellhayes merged 10 commits intomainfrom
rossellhayes merged 10 commits intomainfrom
Conversation
Member
|
Very nice! |
gadenbuie
approved these changes
Oct 5, 2022
Contributor
Author
|
@gadenbuie One final detail worth reviewing before I merge. 569f506 adds support for finding unnamed arguments with an empty string, like this: library(gradecode)
find_arguments("mean(1:10, na.rm = TRUE)", match = "")
#>
#> ── gradecode found ─────────────────────────────────────────────────────────────
#> mean(1:10, na.rm = TRUE)
#>
#> ── Request ──
#> argument ""
#> Found 1 result.
#>
#> ── Result 1 ──
#> mean(1:10, na.rm = TRUE)
#> ‾‾‾‾Created on 2022-10-06 with reprex v2.0.2 Is that a good interface? ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
matchargument offind_arguments()is a character vector, find arguments by name regardless of value.If
matchis a character vector of length > 1, find any of those arguments.Created on 2022-10-05 with reprex v2.0.2
Closes #45.