Skip to content

fix: close open file handles in pin_download #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2023
Merged

fix: close open file handles in pin_download #208

merged 1 commit into from
Aug 15, 2023

Conversation

@cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Aug 9, 2023

This PR closes open file handles to avoid resource leakage from only accessing the file name.

isabelizimm
isabelizimm approved these changes Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@isabelizimm isabelizimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for this change 🙌 I'll plan to merge once CI passes.

@isabelizimm isabelizimm merged commit 917ca3a into rstudio:main Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isabelizimm isabelizimm isabelizimm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cpcloud @isabelizimm