Skip to content

Conversation

@dfalbel
Copy link
Member

@dfalbel dfalbel commented Jun 19, 2019

Delegates installation to reticulate functions.

I have set testing for different envs and OS's here: https://github.com/dfalbel/tfinstall

@javierluraschi
Copy link
Contributor

LGTM!

@skeydan
Copy link

skeydan commented Jun 21, 2019

To me too, great! Just asking about d71d12f, when I create a default new environment

conda create -n new python=3.7

I get these automatically:

-rw-rw-r--.  5 key key      132 Jun  9 22:30 libgcc_s.so
-rw-rw-r--.  5 key key   818984 Jun  9 22:30 libgcc_s.so.1

@dfalbel
Copy link
Member Author

dfalbel commented Jun 21, 2019

You are right! I fixed this here: 4c58d7e#diff-b5f7f6437b8e3c21cb2e9d6eb0ce1dd8L138

I added a conda_python_version argument to control which python version is installed in this env. Currently using 3.6.8 since 3.7 has some ABI incompatibility issues with tensorflow.

@dfalbel dfalbel merged commit 62be607 into rstudio:master Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants